He career began as a child actor and his first film appearance was in the 1934 film Power. Other film appearances included The Traitors and Rest in Pieces. During the Second World War acted with army theatre units in Italy and occupied Germany.
Television roles included parts in No Hiding Place, The Plane Makers, Emergency-Ward 10, The Forsyte Saga, Softly Softly, Hadleigh, UFO, General Hospital, Z Cars, The Pallisers, The Sweeney, Dad's Army, Bless Me Father (both with Arthur Lowe), Are You Being Served?, To Serve Them All My Days, Yes, Minister, Lytton's Diary and Jonathan Creek.
Stage roles included For Services Rendered and The Man Who Came to Dinner and for some years was a member of the Royal Shakespeare Company. On radio, he was a member of the BBC Drama Repertory Company in the 1950s, both as an actor and a writer. He appeared in many Saturday Night Theatre productions and wrote for Mrs Dale's Diary among many other programmes.